I've reworked SO many systems that started clean and were obviously updated by a series of different people over a span of years. New features nailed on with apparently little understanding of the overall app. It's like, "Oh dude it was already doing 90% of what you wanted, you didn't have to add all this... ." Especially true when offshore contract agencies had been involved - to churn through jobs as fast as possible (with no other concern) they tend to copypaste sections of the app that do something similar to what's desired, and make minimal changes to them, with zero code cleanup. This leaves all sorts of misleading unnecessary code, as well as inefficiencies like grabbing a large dataset to get a single item, etc. I found things that made me literally LOL.

[–] chunkystyles@sopuli.xyz 11 points 1 day ago (1 children)

Our off shore contractors produce some of the worst code. But it's impossible to get work done and also be vigilant enough to reject their bad pull requests. So basically you'll end up looking a code one day that is godawful and think, "this is off shore". And yep, git blame tells you you're right.

[–] asdfasdfasdf@lemmy.world 2 points 6 hours ago (1 children)

How do code reviews work with contractors? Is it just "you don't get paid until we approve it"?

[–] chunkystyles@sopuli.xyz 2 points 4 hours ago

It's a contracting agency. Not individual contractors. Unfortunately we have lots of rubber stampers on our team who approve code while you're not looking. And let me be clear, we have on shore who contribute awful code, too.

It's all a mess.

[–] sik0fewl@lemmy.ca 2 points 1 day ago

I just need to add 20 if-branches in 15 methods across 10 different files from 5 modules.