this post was submitted on 02 Jul 2024
928 points (98.5% liked)

Programmer Humor

19187 readers
1136 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
928
Looks good to me ๐Ÿ‘ (i.ibb.co)
submitted 2 months ago by ZeroCool@feddit.org to c/programmer_humor@programming.dev
26 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[โ€“] jubilationtcornpone@sh.itjust.works 42 points 2 months ago (2 children)

Reviewing large PR's is hard. Breaking apart large PR's that are all related changes into smaller PR's is also hard.

If I submit a big one, I usually leave notes in the description explaining where the "core" changes are and what they are trying to accomplish. The goal being to give the reviewers a good starting point.

I also like to unit test the shit out of my code which helps a lot. The main issue there is getting management to embrace unit tests. Unit tests often double the effort up front but save tons of time in the long run. We're going to spend the time one way or the other. Better to do it up front when it's "cheaper" because charging it to the tech debt credit card racks up lots of expensive interest.

[โ€“] zalgotext@sh.itjust.works 13 points 2 months ago

I can't believe we still have to justify writing unit tests to management in the year 2024

[โ€“] pageflight@lemmy.world 11 points 2 months ago

Yeah, if you don't want the next dev (or your future self) to accidentally undo that corner case you fixed, better put a unit test on it.