Programmer Humor

9 readers

2 users here now

wat doing

founded 1 year ago

165

Code Review (media.kbin.social)

submitted 1 year ago by Lenguador@kbin.social to c/programmerhumor@kbin.social

13 comments fedilink hide all child comments

top 12 comments

sorted by: hot top controversial new old

[–] HubertManne@kbin.social 12 points 1 year ago (1 children)

I hate places without code review. Makes me nervous as heaven to merge code and want as many double checks as possible.

[–] Noumena@kbin.social 3 points 1 year ago* (last edited 1 year ago) (2 children)

I feel this way about open source and the seemingly frequent lack of detailed code reviews. This one project had two function options to use from a library. One handles errors by returning them to the caller so they can be handled gracefully. The other, calls PANIC! They chose the latter and it causes a crash loop for a relatively easy to hit code condition that is sensitive to User input.

Why ask for unit test, in the code review, when you can just accept the contribution for a feature that is used in large corps.

[–] HubertManne@kbin.social 2 points 1 year ago

I will say I hate having to pester folks to do review on a merge. The place im currently at requires two and its pulling teeth to get folks to look at someone elses code. well except for me I always treat merges as priority as that is ready to go whereas with mine if I have not merged then its not that ready.

[–] nightauthor@kbin.social 1 points 1 year ago

Down with the corps?

[–] Derickdoes@lemmy.sdf.org 8 points 1 year ago

Found my Senior Engineer

[–] rodhlann@kbin.social 8 points 1 year ago

I hate code reviews because for whatever stupid reason my brain decides this is how it is.

I was at an XP shop for a few years before my current job and I forgot how much I hate code reviews because we were constantly pairing and didn't do reviews in the same way. Coming back to the standard sort of code review model has been torture.

[–] sentient_loom@kbin.social 5 points 1 year ago

When I do code reviews it is a personal attack. I only suggest code changes on my enemy's pull requests.

[–] AnarchoGravyBoat@kbin.social 2 points 1 year ago (1 children)

@Lenguador

Code reviews are only bad until you realize you can just say "cool story bro" and move on.

No change is always an acceptable response to review comments imo, unless it's one of mine.

If you can't defend that turd of a code unit, why the hell do you think it deserves to go into production?

[–] Lenguador@kbin.social 1 points 1 year ago

Thanks for the advice, but I actually love code reviews.

[–] TechyShishy@kbin.social 2 points 1 year ago

"I don't understand what these two lines of code do, could you please modify, explain, or document." is very different from "I don't like the semantics of this function, replace it with this other one that does something unrelated."

We've worked at both places, and one is useful, the other... not so much.

[–] V699@kbin.social 1 points 1 year ago

oof this is too real lol

[–] Xeelee@kbin.social 1 points 1 year ago

What are you talking about? Of course it is! Real men don't do doc strings!

load more comments