this post was submitted on 13 May 2024
4 points (61.1% liked)

C++

1723 readers
1 users here now

The center for all discussion and news regarding C++.

Rules

founded 1 year ago
MODERATORS
farados@vlemmy.net
Nihili0@programming.dev
lysdexic@programming.dev
4
How to avoid one C++ foot gun (pboyd.io)
submitted 4 months ago by lysdexic@programming.dev to c/cpp@programming.dev
15 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] cmeerw@programming.dev 9 points 4 months ago (2 children)

And even the presented fix hurts my eyes. Should have used a unique_ptr or optional.

[–] rasensprenger@feddit.de 3 points 4 months ago

Exactly, raw pointers are very rarely the way to go

[–] lysdexic@programming.dev 1 points 4 months ago* (last edited 4 months ago) (1 children)

You'd be missing the whole point too if you think that the pointer is the root cause. The problem is that the class is not designed to be copy-able, let alone moveable. Your suggestion to use a unique_ptr will also blow up in your face the moment you try to copy an instance.

[–] cmeerw@programming.dev 2 points 4 months ago (1 children)

Depends on what semantic you want. Sure, if you use a unique_ptr member, you will get a deleted copy constructor/operator - I wouldn't consider that blowing up in my face.