Even if you do design clean modular code and document it, you’re getting a question a year from now about how it works, or someone just duct tapes on top of it.

[–] BakedCatboy@lemmy.ml 38 points 7 months ago

I've even experienced this in the 3D printing community, where I design a highly parametric model and put lots of effort into making all of the major dimensions and qualities parameterized and dynamically adjustable, with lots of bounds checking and value clamping, with all the parameters at the top of my scad file with comments explaining what each variable does.

And then someone comes along to remix my model, says I don't want to install openscad, and just scales the entire output stl to change the dimensions, squashing all the features of the model in the process (instead of having the size gracefully adjust with all the features moving around to account), and leaving anybody starting from their work with a hard to remix mesh with no parameters.

[–] FMT99@lemmy.world 21 points 7 months ago* (last edited 7 months ago) (1 children)

Or business decides all specs and design decisions that were made last quarter were actually garbage and yes we do want to be able to manually override every step of the carefully designed state machine. We'd like to be able to manually change all calculated sales data, but also the data needs to remain in a consistent state at all times. Oh and while you're there, we decided the commission calculations will use a different system from now on. We expect it to be online by the end of the week, thanks.

[–] SolarMech@slrpnk.net 1 points 7 months ago

The closest I got to this kind of job., is the closest I got to running away. I'm much happier elsewhere now.

[+] amirul@programming.dev 19 points 7 months ago* (last edited 6 months ago) (3 children)

[removed by mod]

[–] adespoton@lemmy.ca 15 points 7 months ago

At least they can observe the patterns….

Bless your heart.

[–] mokus@lemmy.blahaj.zone 5 points 7 months ago

In my experience, this often doesn’t happen. So many developers are either inexperienced or cowboys, and there’s nothing inherently wrong with either. But at places where projects are small and numerous, teams often end up with nothing but a combination of the two.

As one of our office’s engineering “fixers”, I’ve taken over maintenance of several such projects. They usually have shattered remnants of code taken from other projects, open source libraries, internal libraries, stack overflow, and so on. Whole source files copied into the project, modified in ways that introduce impressive new failure cases while failing to add new functionality, and used in ways that completely ignore the features natively implemented in that code while those same features are bodged in as barely-working piles of if statements, balanced on a knife’s edge to avoid triggering the failure modes added by the project’s modifications of the copied code. I’m usually able to purge 20-30k lines of code from such projects in the first month, simultaneously closing multiple outstanding issues the PM had been led to believe were intractable.

That probably sounds like arrogance and/or shitting on everybody else’s work but it’s just reality at many workplaces due to a pace driven by unreasonable expectations from management. I just happen to be the person here that ends up sifting through the wreckage when a project reaches the inevitable osteoporosis phase, because of a natural disposition for reverse engineering. It would be great to escape for this and other reasons, as far as I can tell, most places aren’t that different.

[–] FizzyOrange@programming.dev 2 points 7 months ago

This can work for junior devs who aren't stuck in their ways. Unfortunately there are too many "senior" devs who are happy making crap. It's hard to fight them constantly to do things properly (e.g. write actual commit messages rather than just "Fix #836") so using tools like linters where possible is definitely a big improvement.

[–] JayDee@lemmy.ml 11 points 7 months ago* (last edited 7 months ago)

The 'document' part also seems to be insanely hit-or-miss from my amateur experience. Self-documenting design/code is... well, not. Auto-generated documentation is also usually just as bad IMO. Producing good documentation really is a skill in and of itself.

Also small personal opinion: If your abstraction layers or algorithms are based off a technical concept, you should probably attribute that concept and provide links to further research, to eliminate future ambiguity or in case your reader lacks that background. Future you will probably thank you and anyone like me who immediately gets lost in jargon soup will also be thankful.