this post was submitted on 06 Aug 2024
42 points (97.7% liked)

Learn Programming

1625 readers
1 users here now

Posting Etiquette

  1. Ask the main part of your question in the title. This should be concise but informative.

  2. Provide everything up front. Don't make people fish for more details in the comments. Provide background information and examples.

  3. Be present for follow up questions. Don't ask for help and run away. Stick around to answer questions and provide more details.

  4. Ask about the problem you're trying to solve. Don't focus too much on debugging your exact solution, as you may be going down the wrong path. Include as much information as you can about what you ultimately are trying to achieve. See more on this here: https://xyproblem.info/

Icon base by Delapouite under CC BY 3.0 with modifications to add a gradient

founded 2 years ago
MODERATORS
Ategon@programming.dev
JaumeI@programming.dev
bugsmith@programming.dev
42
How to go from writing code that works to writing efficient, clean code and following good practices? (programming.dev)
submitted 4 months ago* (last edited 4 months ago) by andioop@programming.dev to c/learn_programming@programming.dev
29 comments fedilink hide all child comments
 

Besides some of the very, very obvious (don't copy/paste 100 lines of code, make it a function! Write comments for your future self who has forgotten this codebase 3 years from now!), I'm not sure how to write clean, efficient code that follows good practices.

In other words, I'm always privating my repos because I'm not sure if I'm doing some horrible beginner inefficiency/bad practice where I should be embarrassed for having written it, let alone for letting other people see it. Aside from https://refactoring.guru, where should I be learning and what should I be learning?

you are viewing a single comment's thread
view the rest of the comments
[–] magic_lobster_party@kbin.run 5 points 4 months ago (2 children)

It depends on what type of programming you’re doing.

But for OOP, my favorite patterns are composition over inheritance and dependency injection (with constructor injection). Once you know these two the rest will follow naturally, and your programs will turn more modular and easier to maintain.

One common misconception about dependency injection is that you need a framework for it. That’s not the case. Frameworks only make some stuff more convenient, but you can do without it.

Otherwise, I think the best way to learn is by doing. It’s easier to see why a pattern is important when you have first hand experience of how painful it is without it.

Edit: Avoid the book “Clean Code”. That book has just done more harm than good in the world.

[–] 0ops@lemm.ee 4 points 4 months ago* (last edited 4 months ago)

I agree on doing. I don't think I've ever picked up a good coding practice by reading about it and doing it, I'm just not wired like that. Not that I didn't read good coding practices, but most of them I dismissed as overkill... until later when I realized that while working to reverse engineer and cleanup my old, ugly, code, I had independently "invented" a lot of those practices that I had originally dismissed.

That's the test right there imo, you can't really know how bad your code is until you've been away from it long enough to no longer have memory of your intentions on your side. "Wtf is this variable for again? When I figure it out I'll rename it to be more descriptive". "What? This function is doing way more than it's name implies. Tf was I thinking?"

[–] andioop@programming.dev 2 points 4 months ago* (last edited 4 months ago)

For people reading this thread later on, this post and this post elaborate a little more on why to avoid the book "Clean Code".