I'm not talking once or twice either. at least a year of that bullshit. i had to show my boss how many hours of wasted time it was taking me because I look at the code first, like literally anybody. Eventually boss pipd them and fired them but holy fuck i wanted to kick that douche in the groin every time i saw a pr with their name on it.

next place I work I'm insisting on a build step success to assign a pr.

[–] smiletolerantly@awful.systems 4 points 2 weeks ago (2 children)

Lmao, what, that's wild. How did they justify this??

[–] GreenKnight23@lemmy.world 6 points 2 weeks ago (1 children)

"it works on my machine."

It's funny that that's the answer that they always gave, considering there were times that we had screen shares, and I asked them to walk me through how they actually got it to work.

When they attempted to try to run it, unsurprisingly it broke.

There were even a few times that I didn't even review it and the first step I took was to inform them that it wouldn't run. Also, unsurprisingly, I was right.

Management at the time was driven by product development and delivery of "high-value" features. As long as deliverables were delivered, this dev could do anything they wanted to. At the end of a year, I'd lost about four weeks of productivity. That doesn't even cover the hours of after work time that I spent on trying to fix their fuckups.

Needless to say, I stopped doing that. I used to be a nice guy to work with, but now... Let's just say if you can't do the work, I'm not covering for you. If your PR doesn't get merged because it's broken and you can't fix it and you spend six weeks trying to fix it, that's on you.

[–] smiletolerantly@awful.systems 5 points 2 weeks ago* (last edited 2 weeks ago)

Oof.

My employer pays a buttload of money to CircleCI - for extensive checks (build, lint, formatting, full test suite, as well as custom scripts for translation converage, docs,... for the full tech stack) on every push. Reviews start only when everything passes.

I think you have given me a new-found appreciation for the reasoning behind that decision... 😄